Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add upload e2e snapshots workflow #1154

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Jan 24, 2022

No description provided.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #1154 (7b4a100) into master (db6fb66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1154   +/-   ##
=======================================
  Coverage   26.13%   26.13%           
=======================================
  Files         114      114           
  Lines       10833    10833           
=======================================
  Hits         2831     2831           
  Misses       7790     7790           
  Partials      212      212           
Flag Coverage Δ
be_integration_test_latest 29.90% <ø> (ø)
be_integration_test_v4.0.1 28.76% <ø> (ø)
be_unit_test 23.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6fb66...7b4a100. Read the comment docs.

Comment on lines +20 to +23
- feature_version: 6.0.0
tidb_version: nightly
- feature_version: 5.0.0
tidb_version: v5.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you expecting that the E2E artifacts are different in different version matrixes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. But there's different test cases in different version matrixes. May have different use for snapshot.

@shhdgit
Copy link
Member Author

shhdgit commented Jan 26, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7b4a100

@shhdgit shhdgit merged commit 9234b22 into pingcap:master Jan 26, 2022
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request Mar 16, 2022
* test: add upload e2e snapshots workflow

* test: update cypress env

* fix: actions/checkout ref
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request Mar 16, 2022
* test: add upload e2e snapshots workflow

* test: update cypress env

* fix: actions/checkout ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants