feat: init optimizer trace #1187
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
- Coverage 29.43% 29.43% -0.01%
==========================================
Files 286 287 +1
Lines 16944 16945 +1
Branches 648 648
==========================================
Hits 4988 4988
- Misses 11725 11726 +1
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -0,0 +1,86 @@ | |||
| import React, { useEffect, useRef, useMemo } from 'react' | |||
| import Viz from 'viz.js' | |||
There was a problem hiding this comment.
-
viz.js is not maintained. I doubt whether it will cause problems for us.
-
How large will the frontend compiled code become when we are now carrying viz.js in? Will it be too slow to load in cloud environments?
-
As something running in the browser, how is the performance when it meets large JSON to be visualized? Will it cause the browser to freeze?
There was a problem hiding this comment.
-
Yes! viz.js is probably not a good choice. I've replaced it with d3-graphviz.
-
Optimizer trace has been split into a separate module. So it shouldn't affect first screen load.
-
d3-graphviz use wasm to compute the graphviz layout in the web-worker so that it may not freeze the browser.
There was a problem hiding this comment.
Cool, d3-graphviz looks promising! It is interesting that WASM load is fine even in esbuild..
|
/cc @breeswish @baurine @YiniXu9506 |
…ard into feat/optimizer-trace
|
@YiniXu9506: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 142b6bd
|
* feat: init optimizer trace * update: logical optimizer * tweak: optimizer trace layout * fix: index * update: icon * update: deps * tweak: some styles * udpate: step interface * tweak: logical optimization step * tweak: final * tweak: unselected candidates style * update: unselected candates style * deps: use d3-graphviz * chore: remove webpack chunk name comment * tweak: error boundary * chore: clear some deps * tweak: action info tooltip
* feat: init optimizer trace * update: logical optimizer * tweak: optimizer trace layout * fix: index * update: icon * update: deps * tweak: some styles * udpate: step interface * tweak: logical optimization step * tweak: final * tweak: unselected candidates style * update: unselected candates style * deps: use d3-graphviz * chore: remove webpack chunk name comment * tweak: error boundary * chore: clear some deps * tweak: action info tooltip
/optimizer_trace