Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak: add more slow query basic fields #1445

Merged
merged 2 commits into from
Dec 1, 2022
Merged

tweak: add more slow query basic fields #1445

merged 2 commits into from
Dec 1, 2022

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Dec 1, 2022 •
edited
Loading

Related to: #1451

image

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022 •
edited
Loading

Codecov Report

Merging #1445 (d70adcc) into master (74a12a9) will increase coverage by 18.20%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1445       +/-   ##
===========================================
+ Coverage   11.19%   29.40%   +18.20%     
===========================================
  Files         156      128       -28     
  Lines       13115    10530     -2585     
  Branches      103      103               
===========================================
+ Hits         1468     3096     +1628     
+ Misses      11525     7254     -4271     
- Partials      122      180       +58
Flag Coverage Δ
backend_integration ?
backend_ut 27.57% <ø> (?)
e2e_test 62.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a12a9...d70adcc. Read the comment docs.

@shhdgit shhdgit marked this pull request as ready for review December 1, 2022 12:10
@shhdgit
Copy link
Member Author

shhdgit commented Dec 1, 2022

Merged first for the 12.02 release.

@shhdgit shhdgit merged commit 70cfc86 into pingcap:master Dec 1, 2022
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request Dec 1, 2022
@shhdgit
tweak: add more slow query basic fields (pingcap#1445)
b9482b4 
* tweak: add more slow query basic fields

* tweak: i18n
shhdgit added a commit that referenced this pull request Dec 1, 2022
@shhdgit @SabaPing @baurine
Release 20221201.1 (#1446)
ea3ee69 
* Upgrade go version to 1.18; fix test in ci pipeline (#1437)

* upgrade go version to 1.18

* update github action go-version to 1.18

* try to fix ci

* Docker image support and misc. improvements (#1439)

* test: support iframe full window / full screen / open in new tab (#1442)

* support full window

* support full screen

* support show in an new tab

* tweak: add more slow query basic fields (#1445)

* tweak: add more slow query basic fields

* tweak: i18n

* Update release version

* chore: update i18n

Co-authored-by: Yifan Xu <xuyifan02@pingcap.com>
Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>
lilyjazz
lilyjazz reviewed Dec 1, 2022
View reviewed changes
ui/packages/tidb-dashboard-lib/src/apps/SlowQuery/translations/zh.yaml
@@ -21,6 +21,12 @@ slow_query:
is_internal: 是否为内部 SQL 查询
is_success: 是否执行成功
is_success_tooltip: SQL 查询是否执行成功
is_prepared: Is Prepared?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否执行准备？

lilyjazz
lilyjazz reviewed Dec 1, 2022
View reviewed changes
ui/packages/tidb-dashboard-lib/src/apps/SlowQuery/translations/zh.yaml
@@ -21,6 +21,12 @@ slow_query:
is_internal: 是否为内部 SQL 查询
is_success: 是否执行成功
is_success_tooltip: SQL 查询是否执行成功
is_prepared: Is Prepared?
is_prepared_tooltip: 是否由 prepare 语句生成
is_plan_from_cache: Is Plan from Cache?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否使用计划缓存？

lilyjazz
lilyjazz reviewed Dec 1, 2022
View reviewed changes
ui/packages/tidb-dashboard-lib/src/apps/SlowQuery/translations/zh.yaml
is_prepared_tooltip: 是否由 prepare 语句生成
is_plan_from_cache: Is Plan from Cache?
is_plan_from_cache_tooltip: 查询计划是否来自缓存
is_plan_from_binding: Is Plan from Binding?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否绑定执行计划？

Copy link
Member Author

@shhdgit shhdgit Dec 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d0228dd

Here~ Tooltip is not necessary, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyjazz lilyjazz lilyjazz left review comments

@baurine baurine Awaiting requested review from baurine

@YiniXu9506 YiniXu9506 Awaiting requested review from YiniXu9506

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shhdgit @ti-chi-bot @codecov-commenter @lilyjazz