Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: add resource manager api #1511

Merged
merged 7 commits into from
Apr 20, 2023
Merged

pkg: add resource manager api #1511

merged 7 commits into from
Apr 20, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Apr 11, 2023

No description provided.

@HuSharp
add resource manager api
31ffc7e 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 11, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • baurine

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@HuSharp HuSharp changed the title add resource manager api pkg: add resource manager api Apr 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023 •
edited
Loading

Codecov Report

Merging #1511 (252d49c) into master (96f8d98) will decrease coverage by 0.01%.
The diff coverage is 22.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
- Coverage   24.73%   24.72%   -0.01%     
==========================================
  Files         167      168       +1     
  Lines       14937    15003      +66     
==========================================
+ Hits         3695     3710      +15     
- Misses      10971    11022      +51     
  Partials      271      271
Flag Coverage Δ
backend_integration 9.03% <22.72%> (+0.11%) ⬆️
backend_ut 27.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f8d98...252d49c. Read the comment docs.

@HuSharp HuSharp force-pushed the support_resource_manager_api branch 3 times, most recently from 1b3f1a9 to c1b3358 Compare April 11, 2023 09:32
@HuSharp
update parameters
ac7df45 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the support_resource_manager_api branch from c1b3358 to ac7df45 Compare April 11, 2023 09:37
@HuSharp
address comment
ead3886 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the support_resource_manager_api branch from fa3c1ad to f1b5930 Compare April 19, 2023 13:58
@HuSharp
update constraints
5e0e27a 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the support_resource_manager_api branch from f1b5930 to 5e0e27a Compare April 20, 2023 00:51
@HuSharp HuSharp marked this pull request as ready for review April 20, 2023 01:16
@HuSharp
keep compatibility
548e55c 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
address comment
76df64b 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
address comment
252d49c 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@baurine baurine merged commit b0aec70 into pingcap:master Apr 20, 2023
baurine pushed a commit that referenced this pull request May 8, 2023
@HuSharp @baurine
pkg: add resource manager api (#1511)
65110d9 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
baurine added a commit that referenced this pull request May 8, 2023
@baurine @guo-shaoge
@HuSharp @mornyx
Release v2023.05.08.1 [skip pd_pr] (#1523)
d6e0218 
* distinguish tiflash_compute node (#1513)

* pkg: add resource manager api (#1511)


Signed-off-by: husharp <jinhao.hu@pingcap.com>

* slowquery: fix 500 when parsing binary plan fails (#1518)

Signed-off-by: mornyx <mornyx.z@gmail.com>

* feat: implement resource manager app (#1514)

* fix: fix monitoring doc ref link for tidb-dashboard op (#1520)

* fix: hide capacity warning if estimate ru fails (#1521)

* refine: add tidb and tikv cpu quota for resource manager (#1522)

* update version: 2023.05.08.1

---------

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
Co-authored-by: Hu# <ihusharp@gmail.com>
Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
@HuSharp HuSharp deleted the support_resource_manager_api branch April 7, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baurine baurine baurine approved these changes

Assignees
No one assigned
Labels
release-7.1 status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HuSharp @ti-chi-bot @CLAassistant @codecov-commenter @baurine