Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use topology for ticdc #1643

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

CharlesCheung96
Copy link
Contributor

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai January 26, 2024 07:16
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit e3e032f
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65c2da41f9d4b100086b0b96
😎 Deploy Preview https://deploy-preview-1643--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a2a7adb) 9.17% compared to head (e3e032f) 24.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1643       +/-   ##
===========================================
+ Coverage    9.17%   24.11%   +14.93%     
===========================================
  Files         127      173       +46     
  Lines       13401    15715     +2314     
===========================================
+ Hits         1230     3789     +2559     
+ Misses      12040    11642      -398     
- Partials      131      284      +153     
Flag Coverage Δ
backend_integration 9.14% <0.00%> (-0.04%) ⬇️
backend_ut 26.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a7adb...e3e032f. Read the comment docs.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-27 08:01:08.367239649 +0000 UTC m=+1206909.931537338: ☑️ agreed by baurine.
  • 2024-01-27 08:01:29.074421365 +0000 UTC m=+1206930.638719067: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Jan 27, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2024

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2024

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine, mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baurine baurine merged commit b855204 into pingcap:master Feb 19, 2024
14 of 16 checks passed
baurine pushed a commit that referenced this pull request Feb 19, 2024
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
baurine pushed a commit that referenced this pull request Feb 28, 2024
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
baurine pushed a commit that referenced this pull request Mar 27, 2024
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants