Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forwarder: close goroutine leak when block in accept #1644

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Jan 31, 2024

related tikv/pd#7782

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit cce4e52
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65c1dfe9addb9d0008563ebf

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.17%. Comparing base (5e932ec) to head (cce4e52).
Report is 16 commits behind head on master.

Current head cce4e52 differs from pull request most recent head f3b363d

Please upload reports for the commit f3b363d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
+ Coverage   23.68%   24.17%   +0.49%     
==========================================
  Files         177      173       -4     
  Lines       16055    15725     -330     
==========================================
- Hits         3802     3801       -1     
+ Misses      11968    11638     -330     
- Partials      285      286       +1     
Flag Coverage Δ
backend_integration 9.29% <91.66%> (+0.30%) ⬆️
backend_ut 26.28% <54.16%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f979...f3b363d. Read the comment docs.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp changed the title leak: fix leak forwarder: close goroutine leak when block in accept Feb 6, 2024
@HuSharp HuSharp marked this pull request as ready for review February 6, 2024 07:37
@HuSharp
Copy link
Contributor Author

HuSharp commented Feb 6, 2024

@shhdgit @baurine PTAL, thx!

@baurine
Copy link
Collaborator

baurine commented Feb 6, 2024

@mornyx please help review , thanks~

Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deardrops for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants