-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forwarder: close goroutine leak when block in accept #1644
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tidb-dashboard canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
+ Coverage 23.68% 24.17% +0.49%
==========================================
Files 177 173 -4
Lines 16055 15725 -330
==========================================
- Hits 3802 3801 -1
+ Misses 11968 11638 -330
- Partials 285 286 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@mornyx please help review , thanks~ |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related tikv/pd#7782