feat(slow-query): support slow query search by resource group #1646
Conversation
✅ Deploy Preview for tidb-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1646 +/- ##
===========================================
+ Coverage 9.15% 24.10% +14.95%
===========================================
Files 127 173 +46
Lines 13375 15710 +2335
===========================================
+ Hits 1224 3787 +2563
+ Misses 12020 11639 -381
- Partials 131 284 +153
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Signed-off-by: nolouch <nolouch@gmail.com>
|
PTAL @baurine |
|
Get, in reviewing. |
| @@ -119,6 +131,7 @@ export const ctx: (extra: DsExtra) => ISlowQueryContext = (extra) => ({ | |||
| apiPathBase: client.getBasePath(), | |||
| enableExport: false, | |||
| showDBFilter: false, | |||
| showDigestFilter: false | |||
| showDigestFilter: false, | |||
| showResourceGroupFilter: true | |||
There was a problem hiding this comment.
For clinic-op, I feel showResourceGroupFilter is better to false, although in this case, true and false are the same result.
There was a problem hiding this comment.
What do clinic-op and clinic-could stand for? dedicated and serverless?
There was a problem hiding this comment.
clinic-op for the OP clusters, they can collect the diagnosis data by tiup diag tool in local and upload to clinic server, while clinic-cloud for the cloud clusters (dedicated and serverless both).
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baurine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
support slow query search by resource group
MultiSelectExample:
