Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slow-query): support slow query search by resource group #1646

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Feb 1, 2024

support slow query search by resource group

  • If there are above 2 resource groups in the cluster, will show the MultiSelect
  • Add relative API

Example:
image

@ti-chi-bot ti-chi-bot bot requested a review from Renkai February 1, 2024 19:36
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 4ada671
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65bbf3329e7a3b000976b04f
😎 Deploy Preview https://deploy-preview-1646--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot added the size/XL label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (2171c6e) 9.15% compared to head (4ada671) 24.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1646       +/-   ##
===========================================
+ Coverage    9.15%   24.10%   +14.95%     
===========================================
  Files         127      173       +46     
  Lines       13375    15710     +2335     
===========================================
+ Hits         1224     3787     +2563     
+ Misses      12020    11639      -381     
- Partials      131      284      +153     
Flag Coverage Δ
backend_integration 9.14% <4.76%> (-0.01%) ⬇️
backend_ut 26.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2171c6e...4ada671. Read the comment docs.

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Member Author

nolouch commented Feb 2, 2024

PTAL @baurine

@baurine
Copy link
Collaborator

baurine commented Feb 4, 2024

Get, in reviewing.

@@ -119,6 +131,7 @@ export const ctx: (extra: DsExtra) => ISlowQueryContext = (extra) => ({
apiPathBase: client.getBasePath(),
enableExport: false,
showDBFilter: false,
showDigestFilter: false
showDigestFilter: false,
showResourceGroupFilter: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clinic-op, I feel showResourceGroupFilter is better to false, although in this case, true and false are the same result.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do clinic-op and clinic-could stand for? dedicated and serverless?

Copy link
Collaborator

@baurine baurine Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clinic-op for the OP clusters, they can collect the diagnosis data by tiup diag tool in local and upload to clinic server, while clinic-cloud for the cloud clusters (dedicated and serverless both).

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-06 03:32:06.105299795 +0000 UTC m=+241251.672069669: ☑️ agreed by baurine.

Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit e6ac0d1 into pingcap:master Feb 6, 2024
15 of 16 checks passed
@nolouch nolouch deleted the add-select branch February 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants