Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statements): support statement search by resource group #1647

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Feb 6, 2024

support statement search by resource group

  • If there are above 2 resource groups in the cluster, will show the MultiSelect
  • Add relative API

Example:
image

@ti-chi-bot ti-chi-bot bot requested a review from Renkai February 6, 2024 18:40
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit efeb658
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65c27e1f793de70008d40220

@ti-chi-bot ti-chi-bot bot added the size/L label Feb 6, 2024
Signed-off-by: nolouch <nolouch@gmail.com>
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e6ac0d1) 24.11% compared to head (efeb658) 24.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1647      +/-   ##
==========================================
- Coverage   24.11%   24.09%   -0.03%     
==========================================
  Files         173      173              
  Lines       15710    15715       +5     
==========================================
- Hits         3789     3787       -2     
- Misses      11637    11644       +7     
  Partials      284      284              
Flag Coverage Δ
backend_integration 9.14% <0.00%> (-0.01%) ⬇️
backend_ut 26.25% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ac0d1...efeb658. Read the comment docs.

@baurine baurine changed the title feat(statements): support slow query search by resource group feat(statements): support statement search by resource group Feb 7, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-07 01:16:30.790446869 +0000 UTC m=+319516.357216898: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit a2a7adb into pingcap:master Feb 7, 2024
14 of 16 checks passed
@nolouch nolouch deleted the statement-filter branch February 7, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants