-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend supports for tso and scheduling #1648
Conversation
✅ Deploy Preview for tidb-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
- Coverage 24.08% 23.67% -0.42%
==========================================
Files 173 177 +4
Lines 15754 16040 +286
==========================================
+ Hits 3795 3798 +3
- Misses 11675 11958 +283
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
@mornyx PTAL |
I will help review next week. @rleungx , can you elaborate the PR when you're free, for example, how to build the dev env so I can test the PR, attach some screenshots. thanks~ |
test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code LGTM, let me test the compatibility with old version cluster
fix the following errors in commit: c0d1625 , after cherry-pick this commit, this PR is able to be approved. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
1d68134
to
a86edef
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baurine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
The component name might be changed later. Ref #1651