fix: correctly display the disk mount points of tiflash #1649
Conversation
Signed-off-by: mornyx <mornyx.z@gmail.com>
✅ Deploy Preview for tidb-dashboard canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
- Coverage 24.12% 24.05% -0.07%
==========================================
Files 173 173
Lines 15717 15749 +32
==========================================
- Hits 3791 3788 -3
- Misses 11642 11677 +35
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
| case "engine-store.storage.main.dir", "engine-store.storage.latest.dir": | ||
| if err := json.Unmarshal([]byte(row.Value), &paths); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
"engine-store.storage.main.dir", "engine-store.storage.latest.dir" These two configs can be set simultaneously. In this case, we need to merge the two array to paths into a set.
| mountDir := locateInstanceMountPartition(path, m[hostname].Partitions) | ||
| if mountDir != "" { | ||
| m[hostname].Instances[row.Instance].PartitionPathL = strings.ToLower(mountDir) | ||
| break |
There was a problem hiding this comment.
If a TiFlash instance is deployed on multiple disks (MountPartition), can we show all mount point usage of that TiFlash instance?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baurine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/cherry-pick release-7.1 |
ti-chi-bot
added
needs-cherry-pick-release-7.5
and removed
needs-cherry-pick-release-7.5
labels
|
/cherry-pick release-7.5 |
close: #1625
In the past, the data directory of tiflash was only obtained from
engine-store.path. This PR modified it to be obtained from bothengine-store.path,engine-store.storage.main.dirandengine-store.storage.latest.dir.