Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go to 1.21 #1709

Merged
merged 4 commits into from
Aug 1, 2024
Merged

update go to 1.21 #1709

merged 4 commits into from
Aug 1, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 30, 2024 •
edited
Loading

  1. update golang to 1.21
  2. update mockery to v2.40.3
  3. update go-lint to 1.59.1
  4. fix some lint
    • unused-parameter
    • SA1019: reflect.StringHeader has been deprecated
    • dot-imports
  5. remove depguard temporary

@lhy1024
update go to 1.21 and update mockery to v2.40.3
9aa6407 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot requested a review from Renkai July 30, 2024 06:30
@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XL label Jul 30, 2024
@lhy1024
fix lint and remove depguard
4d125ae 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/XL labels Jul 30, 2024
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 30, 2024

/retest

@lhy1024
trigger test
dc76b8b 
Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024
lhy1024 commented Jul 30, 2024
View reviewed changes
.golangci.yml

linters:
enable:
# Additionally enable some checkers
- asciicheck
- depguard
# - depguard
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I close it because I am not sure how tidb-dashboard will do about it.

lhy1024
lhy1024 commented Jul 30, 2024
View reviewed changes
pkg/keyvisual/matrix/key.go
@@ -29,7 +27,5 @@ func (km *KeyMap) SaveKeys(keys []string) {
}

func equal(keyA, keyB string) bool {
Copy link
Contributor Author

@lhy1024 lhy1024 Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace it since reflect.StringHeader has been deprecated

lhy1024
lhy1024 commented Jul 30, 2024
View reviewed changes
pkg/keyvisual/region/utils.go
pstring.Data = pbytes.Data
pstring.Len = pbytes.Len
return
func String(b []byte) string {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

lhy1024
lhy1024 commented Jul 30, 2024
View reviewed changes
pkg/keyvisual/region/utils.go
pbytes.Len = pstring.Len
pbytes.Cap = pstring.Len
return
func Bytes(s string) []byte {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

This was referenced Jul 30, 2024
Merged
Closed
@lhy1024
fix panic
c891b19 
Signed-off-by: lhy1024 <admin@liudos.us>
nolouch
nolouch approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
PTAL @baurine @Renkai

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm.
PTAL @baurine @Renkai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 1, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-01 03:41:31.540262464 +0000 UTC m=+413607.820310526: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 1, 2024
@baurine
Copy link
Collaborator

baurine commented Aug 1, 2024

@lhy1024 please sign the CLA, thanks~

@baurine baurine mentioned this pull request Aug 1, 2024
Closed
@ti-chi-bot ti-chi-bot bot merged commit 0941ad4 into pingcap:master Aug 1, 2024
8 checks passed
@baurine
Copy link
Collaborator

baurine commented Aug 14, 2024

/cherry-pick release-8.3

baurine pushed a commit that referenced this pull request Aug 23, 2024
@lhy1024 @baurine
update go to 1.21 (#1709)
01e0b3d
@baurine baurine mentioned this pull request Aug 23, 2024
Merged
baurine added a commit that referenced this pull request Aug 26, 2024
@baurine @lhy1024
update go to 1.21 (#1709) (#1716)
39e90b5 
* update go to 1.21  (#1709)

---------

Co-authored-by: lhy1024 <lhylhy1024@gmail.com>
This was referenced Dec 1, 2024
Closed
Closed
@mornyx
Copy link
Collaborator

mornyx commented Dec 11, 2024

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-7.5: #1759.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-dashboard that referenced this pull request Dec 11, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of pingcap#1709
e3d3e9a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2024
@ti-chi-bot
update go to 1.21 (#1709) (#1759)
4287870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@baurine baurine baurine approved these changes

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lhy1024 @CLAassistant @baurine @mornyx @ti-chi-bot @nolouch