Add ui playground by storybook #691
Conversation
|
Current progress:
Remain a big issue: how to set the API client instance for all stories, still working on it. |
|
Almost done, remain some cleanup work. |
|
Final effects:
Btw, ideally, we should use mocked data for storybook to avoid to depend on an extra service but here we use the real data, I think it is just fine, and maybe we can change it in the later gradually. How do you think about it? @breeswish |
| export default function MultiSelect<T extends IItem>( | ||
| props: IMultiSelectProps<T> | ||
| ) { | ||
| function MultiSelect<T extends IItem>(props: IMultiSelectProps<T>) { |
There was a problem hiding this comment.
Changing to this writing style to fix the storybook runtime error. Ref: storybookjs/storybook#11419 (comment)
| > After the installation, TiUP displays the absolute path of the corresponding `profile` file. You need to modify the following `source` command according to the path. | ||
| > **Note:** | ||
| > | ||
| > After the installation, TiUP displays the absolute path of the corresponding `profile` file. You need to modify the following `source` command according to the path. |
There was a problem hiding this comment.
Auto formatted by the git commit hook.
|
@breeswish PTAL when you're free, thanks! |
ui/package.json
Outdated
| "gen:browserlist": "gulp gen:browserlist" | ||
| "gen:browserlist": "gulp gen:browserlist", | ||
| "storybook": "start-storybook -p 9009 -s public", | ||
| "build-storybook": "build-storybook -s public" |
There was a problem hiding this comment.
Maybe we don't need build-storybook
There was a problem hiding this comment.
I think so, will remove it soon.
| @@ -0,0 +1,23 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
We can drop the standard ant selects
* ui: Add storybook (#691) * build(deps): bump lodash from 4.17.15 to 4.17.19 in /ui/tests (#695) * ui: I18N for form validation (#698) * build(deps): bump lodash from 4.17.15 to 4.17.19 in /ui (#696) * telemetry: Report dashboard internal version (#709) * telemetry: Update router style (#707) *: update system report table name (#693) * build(deps): bump elliptic from 6.5.2 to 6.5.3 in /ui (#712)
close #593