-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ui playground by storybook #691
Conversation
export default function MultiSelect<T extends IItem>( | ||
props: IMultiSelectProps<T> | ||
) { | ||
function MultiSelect<T extends IItem>(props: IMultiSelectProps<T>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to this writing style to fix the storybook runtime error. Ref: storybookjs/storybook#11419 (comment)
> After the installation, TiUP displays the absolute path of the corresponding `profile` file. You need to modify the following `source` command according to the path. | ||
> **Note:** | ||
> | ||
> After the installation, TiUP displays the absolute path of the corresponding `profile` file. You need to modify the following `source` command according to the path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto formatted by the git commit hook.
@breeswish PTAL when you're free, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! We can also create issues to let contributors help us supply more stories for our components.
ui/package.json
Outdated
"gen:browserlist": "gulp gen:browserlist" | ||
"gen:browserlist": "gulp gen:browserlist", | ||
"storybook": "start-storybook -p 9009 -s public", | ||
"build-storybook": "build-storybook -s public" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need build-storybook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, will remove it soon.
@@ -0,0 +1,23 @@ | |||
import React from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop the standard ant selects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
* ui: Add storybook (#691) * build(deps): bump lodash from 4.17.15 to 4.17.19 in /ui/tests (#695) * ui: I18N for form validation (#698) * build(deps): bump lodash from 4.17.15 to 4.17.19 in /ui (#696) * telemetry: Report dashboard internal version (#709) * telemetry: Update router style (#707) *: update system report table name (#693) * build(deps): bump elliptic from 6.5.2 to 6.5.3 in /ui (#712)
close #593