Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine(ui): debug api #927

Merged
merged 33 commits into from
Jun 1, 2021
Merged

refine(ui): debug api #927

merged 33 commits into from
Jun 1, 2021

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented May 17, 2021 •
edited
Loading

  • debug api layout
  • table/db widget
  • add new tidb/pd endpoints
  • add descriptions
2021-05-19.23.53.53.mov

@shhdgit
Copy link
Member Author

shhdgit commented May 20, 2021

Maybe we can add some more detailed descriptions, like this

image

@breezewish
Copy link
Member

Maybe we can add some more detailed descriptions, like this

image

Good idea! Maybe we can further put these descriptions inline (instead of a tooltip).

@shhdgit shhdgit marked this pull request as ready for review May 24, 2021 03:52
@shhdgit
Copy link
Member Author

shhdgit commented May 24, 2021

PTAL!

@breeswish @baurine

@shhdgit
Copy link
Member Author

shhdgit commented May 24, 2021

image

Updated.

shhdgit
shhdgit commented May 24, 2021
View reviewed changes
pkg/httpc/client.go
method string,
body io.Reader,
errType *errorx.Type,
errOriginComponent string) (*Response, error) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary, I will open another pr to refactor the http client.

breezewish
breezewish reviewed May 24, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me! Didn't reviewed the front-end part.

pkg/apiserver/debugapi/endpoint/context.go Show resolved Hide resolved
pkg/apiserver/debugapi/endpoint/endpoint_def.go Outdated Show resolved Hide resolved
pkg/apiserver/debugapi/endpoint/endpoint_def.go Outdated Show resolved Hide resolved
pkg/apiserver/debugapi/endpoint/endpoint_def.go Outdated Show resolved Hide resolved
pkg/httpc/client.go Show resolved Hide resolved
@breezewish
Copy link
Member

There are only 14 review comments this time! 🎉

baurine
baurine approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • baurine

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@shhdgit shhdgit requested a review from breezewish May 26, 2021 02:50
@shhdgit
Copy link
Member Author

shhdgit commented May 26, 2021

Enum looks like

image

breezewish
breezewish reviewed May 27, 2021
View reviewed changes
ui/lib/apps/DebugAPI/apilist/ApiList.tsx
<Root>
<ScrollablePane style={{ height: '100vh' }}>
<Sticky stickyPosition={StickyPositionType.Header} isScrollSynced>
<div style={{ display: 'flow-root' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can provide some wrapper!

@breezewish
Copy link
Member

One last request! :)

Could you also support TiKV /config API? Then we can retrieve all components' config from the Debug API.

The /config API is implemented in https://github.com/tikv/tikv/blob/70ee9c22e2c2485586d280dd0b1a39b353ffced6/src/server/status_server/mod.rs#L727

@shhdgit
Copy link
Member Author

shhdgit commented Jun 1, 2021

Of cause, give me a second.

@shhdgit shhdgit requested a review from breezewish June 1, 2021 01:56
@shhdgit
Copy link
Member Author

shhdgit commented Jun 1, 2021

TiKV /config is supported. 🥳

@breezewish
Copy link
Member

Nice implementation! 🎉🎉🎉

@breezewish breezewish merged commit af63b5b into pingcap:master Jun 1, 2021
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request Jun 15, 2021
@shhdgit
debug_api: Add more endpoints (pingcap#927)
12b0014
breezewish pushed a commit that referenced this pull request Jun 15, 2021
@shhdgit
Release v2021.06.15.1 (#938)
6bbc7e6 
* fix: label of y-axis is overflow (#924)
* update(deps): upgrade gorm to v2 (#916)
* debug_api: Add more endpoints (#927)
* fix(ui): localstorage compatibility issue (#930)
@baurine baurine mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@baurine baurine baurine approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shhdgit @breezewish @ti-chi-bot @baurine