-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vscode info #107
Add vscode info #107
Conversation
cc @dragonly |
|
||
* [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go) | ||
* [TiDE](https://marketplace.visualstudio.com/items?itemName=dragonly.ticode) | ||
* [GitHub Pull Requests and Issues](https://marketplace.visualstudio.com/items?itemName=github.vscode-pull-request-github) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [GitHub Pull Requests and Issues](https://marketplace.visualstudio.com/items?itemName=github.vscode-pull-request-github) |
I think this extension is irrelevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having this extension makes sense as GitHub is core the the contribution workflow. We could mark it as optional, but then we should probably label TiDE as optional as well.
Now install these extensions: | ||
|
||
* [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go) | ||
* [TiDE](https://marketplace.visualstudio.com/items?itemName=dragonly.ticode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I think TiDE is also not mandatory?
Also, GoLand instructions above mainly focus on simple tasks like unistore and unit tests. But TiDE is targeted at more complex tasks (and doesn't support unistore)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes not mandatory, but quite useful. I think users would be smart enough to filter this out if needed and if they don't that's also not really a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it doesn't hurt.
Co-authored-by: xxchan <37948597+xxchan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It provides valuable information to setup dev env on VS Code.
I'll merge this one the next week if there is no further concern.
Merging... Thanks for your contribution @dveeden ! |
setup-an-ide: Add VS Code