Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode info #107

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Add vscode info #107

merged 3 commits into from
Aug 30, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 24, 2021

setup-an-ide: Add VS Code

@dveeden
Copy link
Contributor Author

dveeden commented Aug 24, 2021

cc @dragonly


* [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go)
* [TiDE](https://marketplace.visualstudio.com/items?itemName=dragonly.ticode)
* [GitHub Pull Requests and Issues](https://marketplace.visualstudio.com/items?itemName=github.vscode-pull-request-github)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [GitHub Pull Requests and Issues](https://marketplace.visualstudio.com/items?itemName=github.vscode-pull-request-github)

I think this extension is irrelevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having this extension makes sense as GitHub is core the the contribution workflow. We could mark it as optional, but then we should probably label TiDE as optional as well.

Now install these extensions:

* [Go](https://marketplace.visualstudio.com/items?itemName=golang.Go)
* [TiDE](https://marketplace.visualstudio.com/items?itemName=dragonly.ticode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think TiDE is also not mandatory?

Also, GoLand instructions above mainly focus on simple tasks like unistore and unit tests. But TiDE is targeted at more complex tasks (and doesn't support unistore)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes not mandatory, but quite useful. I think users would be smart enough to filter this out if needed and if they don't that's also not really a problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it doesn't hurt.

Co-authored-by: xxchan <37948597+xxchan@users.noreply.github.com>
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It provides valuable information to setup dev env on VS Code.

I'll merge this one the next week if there is no further concern.

@tisonkun
Copy link
Contributor

Merging...

Thanks for your contribution @dveeden !

@tisonkun tisonkun merged commit 684c3e6 into pingcap:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants