Decouple apply snapshot by introducing pre(post)_apply_snapshot #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
…ikv#12889) ref tikv#12849 Support new observers pre(post)_apply_snapshot. Signed-off-by: CalvinNeo <calvinneo1995@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
CalvinNeo
force-pushed
the
migrate-pre-handle
branch
15 times, most recently
from
beeddef
to
f5da45e
Compare
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
CalvinNeo
force-pushed
the
migrate-pre-handle
branch
from
f5da45e
to
7392cf2
Compare
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
CalvinNeo
force-pushed
the
migrate-pre-handle
branch
from
328c17f
to
12c105d
Compare
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
breezewish
approved these changes
Aug 30, 2022
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
CalvinNeo
force-pushed
the
migrate-pre-handle
branch
from
4292452
to
cc12422
Compare
CalvinNeo
force-pushed
the
migrate-pre-handle
branch
2 times, most recently
from
bf7ac7f
to
937c6b0
Compare
CalvinNeo
force-pushed
the
migrate-pre-handle
branch
from
937c6b0
to
7e9b045
Compare
CalvinNeo
commented
Aug 31, 2022
| for observer in &self.registry.apply_snapshot_observers { | ||
| let observer = observer.observer.inner(); | ||
| let res = observer.post_apply_snapshot(&mut ctx, peer_id, snap_key, snap); | ||
| if res.is_err() { |
CalvinNeo
force-pushed
the
migrate-pre-handle
branch
from
7ddc3cd
to
65b652e
Compare
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
CalvinNeo
force-pushed
the
migrate-pre-handle
branch
from
65b652e
to
b204603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref pingcap/tiflash#5170
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note