Use as less engine_rocks in engine_tiflash as we can #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: CalvinNeo calvinneo1995@gmail.com
What problem does this PR solve?
Issue Number: ref pingcap/tiflash#5170
Problem Summary:
We must own a engine_rocks::RocksEngine, since TiKV has not decouple from engine_rocks yet.
However, we will try to use as less
engine_rocks
inengine_tiflash
as we can, since Proxy will not pick every new features while TiKV is upgrading itsengine_rocks
.The structs that we must import from engine_rocks are:
If we need to keep track of engine_rocks, we can just merge codes from
engine_rocks
toengine_tiflash
, this won't happen frequently, since we don't need much of new features fromengine_rocks
. We adopt them only for compation.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note