Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy config #174

Merged
merged 7 commits into from
Sep 18, 2022
Merged

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Sep 17, 2022

Signed-off-by: CalvinNeo calvinneo1995@gmail.com

What problem does this PR solve?

Issue Number: ref pingcap/tiflash#5170

Problem Summary:

  1. gen_tikv_config is useless if we call TiKvConfig::from_file rather than make_tikv_config. We may turn to use address_proxy_config
  2. ArgMatches in test can't process --config, so it shadows some errors.
  3. We refactor some tests.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

f
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo changed the title f Fix proxy config Sep 17, 2022
f
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

f
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
f
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
f
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
f
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo merged commit ac4614f into pingcap:raftstore-proxy-6.2 Sep 18, 2022
@CalvinNeo CalvinNeo deleted the fix-proxy-config branch October 12, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants