Add info collected from TiDB's server API #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethercflow
reviewed
Aug 20, 2018
| @@ -28,7 +28,7 @@ def __init__(self, args, basedir=None, subdir=None): | |||
| def get_label_names(self): | |||
| result = [] | |||
| url = '%s%s' % (self.url_base, '/label/__name__/values') | |||
| labels = json.loads(util.read_url(url)) | |||
| labels = json.loads(util.read_url(url)[0]) | |||
There was a problem hiding this comment.
Should we handle when util.read_url(url)[0] equals to None?
There was a problem hiding this comment.
We didn't do that before the change, either. I'll do some more work on error handling later, there're more unhandled potential exceptions than this one.
There was a problem hiding this comment.
And BTW, for this particular situation, the return won't be None unless Prom is not working on this node, when trowing the exception will not getting things worse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not available in any TiDB release yet, and v2.0.x does not support this API, so empty result will be generated for unsupported versions.
read_url()to fit needs, more error handling of HTTP calls may be needed