Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

tests: add kill lightning test in checkpoint_chunks case #158

Merged
merged 3 commits into from
Apr 3, 2019

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Apr 3, 2019

What problem does this PR solve?

add test case to cover lightning is killed durning data import

What is changed and how it works?

use gofail to control lightning to kill itself after one chunk is imported

Check List

Tests

  • Integration test

@amyangfei amyangfei added priority/unimportant type/test Changes test cases only qa Quality assurance labels Apr 3, 2019
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei added the status/PTAL This PR is ready for review. Add this label back after committing new changes label Apr 3, 2019
@amyangfei
Copy link
Contributor Author

PTAL @kennytm @lonng

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

done

set +e
while true; do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a retry limit to avoid getting stuck in infinite loop.

@amyangfei
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng merged commit 82ed51b into master Apr 3, 2019
@lonng lonng deleted the yf/test-lightning-kill branch April 3, 2019 08:18
kennytm added a commit that referenced this pull request Apr 4, 2019
* tests: fix a test failure due to conflict between #145 and #158

* restore: apply the row count limit to failpoint KillIfImportedChunk too
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
qa Quality assurance status/PTAL This PR is ready for review. Add this label back after committing new changes type/test Changes test cases only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants