This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
tests: add kill lightning test in checkpoint_chunks case #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
priority/unimportant
type/test
Changes test cases only
qa
Quality assurance
labels
Apr 3, 2019
/run-all-tests |
amyangfei
added
the
status/PTAL
This PR is ready for review. Add this label back after committing new changes
label
Apr 3, 2019
kennytm
reviewed
Apr 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
tests/checkpoint_chunks/run.sh
Outdated
done | ||
|
||
set +e | ||
while true; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a retry limit to avoid getting stuck in infinite loop.
/run-all-tests |
lonng
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
qa
Quality assurance
status/PTAL
This PR is ready for review. Add this label back after committing new changes
type/test
Changes test cases only
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add test case to cover lightning is killed durning data import
What is changed and how it works?
use gofail to control lightning to kill itself after one chunk is imported
Check List
Tests