Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

config: always skip the system databases #225

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Aug 15, 2019

What problem does this PR solve?

Avoid importing the built-in databases (mysql, information_schema, performance_schema and sys).

What is changed and how it works?

Add these 4 databases into the black list in Adjust().

Check List

Tests

  • Integration test

Side effects

  • Breaking backward compatibility
    • User has no way to explicitly restore the tables defined inside mysql.

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@kennytm kennytm added Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated status/PTAL This PR is ready for review. Add this label back after committing new changes type/enhancement Performance improvement or refactoring labels Aug 15, 2019
@kennytm
Copy link
Collaborator Author

kennytm commented Aug 15, 2019

/run-all-tests

@lance6716
Copy link
Contributor

lance6716 commented Aug 15, 2019

LGTM

and I think user can restore those tables (though not the default way) because

If a database’s name matches both the do-dbs and ignore-dbs arrays, the database is included.

@lance6716 lance6716 added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 15, 2019
@kennytm
Copy link
Collaborator Author

kennytm commented Aug 15, 2019

PTAL @csuzhangxc

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Aug 15, 2019
@kennytm kennytm merged commit 1577f31 into master Aug 15, 2019
@kennytm kennytm deleted the kennytm/skip-system-databases branch August 15, 2019 08:59
@ericsyh
Copy link
Contributor

ericsyh commented Aug 27, 2019

@kennytm Pls pick to the 3.0 branch

@kennytm
Copy link
Collaborator Author

kennytm commented Aug 27, 2019

It's already in the 3.0 branch.

@kennytm kennytm removed the Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated label Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) type/enhancement Performance improvement or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants