This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
backend: support stored generated columns in local/importer backends #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
status/PTAL
kennytm
force-pushed
the
kennytm/stored-generated-expressions
branch
from
f212eff
to
8dad811
Compare
kennytm
commented
Dec 2, 2020
| @@ -197,6 +197,7 @@ func newSession(options *SessionOptions) *session { | |||
| vars.StmtCtx.TimeZone = vars.Location() | |||
| vars.SetSystemVar("timestamp", strconv.FormatInt(options.Timestamp, 10)) | |||
| vars.SetSystemVar(variable.TiDBRowFormatVersion, options.RowFormatVersion) | |||
| vars.SetSystemVar(variable.MaxAllowedPacket, strconv.FormatUint(variable.MaxOfMaxAllowedPacket, 10)) | |||
There was a problem hiding this comment.
(the RPAD() function relies on @@max_allowed_packet)
|
LGTM |
glorv
added
status/LGT1
lance6716
approved these changes
Dec 5, 2020
| return nil, logEvalGenExprFailed(logger, row, col, err) | ||
| } | ||
| mutRow.SetDatum(gc.index, value) | ||
| record[gc.index] = value |
There was a problem hiding this comment.
LGTM
Why need these two setter both🤔
There was a problem hiding this comment.
@lance6716 Setting the MutRow is needed for cascading generated columns (think c as b+1 & a as b+1, when calculating c we need to calculate b first).
Setting the record is for inserting the result into the table.
MutRow and []types.Datum can't be cheaply converted between each other so we keep both of them.
lance6716
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Properly support stored generated columns in local/importer backends.
Unlike virtual generated columns, the value of stored generated columns are saved into the KV entries. This is computed before
AddRecord(). Therefore, before this PR, all stored generated columns imported using local or importer backends become NULL.What is changed and how it works?
We now fill in the stored generated columns by evaluating their expressions.
Check List
Tests
Side effects
Related changes
Release notes
Fixed: In local and importer backends, stored generated columns are properly filled in instead of being NULL.