make the drainer name configurable (#1604) (#1783)

* make the drainer name configurable This is used for the statefulset/pod names. The release name is already unique, so I would actually suggest just using that without the cluster name. However, that is a backwards incompatible change that I hesitate to make. * add a warning about updating the drainer name Co-authored-by: Greg Weber <greg@gregweber.info>
pingcap · Feb 26, 2020 · 203fa95 · 203fa95
1 parent 82b114a
commit 203fa95
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/charts/tidb-drainer/templates/_helpers.tpl b/charts/tidb-drainer/templates/_helpers.tpl
@@ -1,4 +1,7 @@
 {{- define "drainer.name" -}}
+{{- if .Values.drainerName }}
+{{ .Values.drainerName }}
+{{- else -}}
 {{ .Values.clusterName }}-{{ .Release.Name }}-drainer
 {{- end -}}
 

diff --git a/charts/tidb-drainer/values.yaml b/charts/tidb-drainer/values.yaml
@@ -5,6 +5,11 @@
 # timezone is the default system timzone
 timezone: UTC
 
+# Change the name of the statefulset and pod
+# The default is clusterName-ReleaseName-drainer
+# Do not change the name of an existing running drainer: this is unsupported.
+# drainerName:
+
 # clusterName is the TiDB cluster name that should backup from or restore to.
 clusterName: demo
 clusterVersion: v3.0.8