-
Notifications
You must be signed in to change notification settings - Fork 499
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* default tidb file log config * fix log error * remove max-size Co-authored-by: Song Gao <2695690803@qq.com>
- Loading branch information
Showing
6 changed files
with
169 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| // Copyright 2020 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package defaulting | ||
|
|
||
| import ( | ||
| . "github.com/onsi/gomega" | ||
| "github.com/pingcap/tidb-operator/pkg/apis/pingcap/v1alpha1" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestSetTidbSpecDefault(t *testing.T) { | ||
| g := NewGomegaWithT(t) | ||
|
|
||
| tc := newTidbCluster() | ||
| setTidbSpecDefault(tc) | ||
| g.Expect(tc.Spec.TiDB.Config).Should(BeNil()) | ||
|
|
||
| tc = newTidbCluster() | ||
| tc.Spec.TiDB.Config = &v1alpha1.TiDBConfig{} | ||
| setTidbSpecDefault(tc) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.File.MaxBackups).Should(Equal(tidbLogMaxBackups)) | ||
|
|
||
| tc = newTidbCluster() | ||
| oomAction := "cancel" | ||
| tc.Spec.TiDB.Config = &v1alpha1.TiDBConfig{ | ||
| OOMAction: &oomAction, | ||
| } | ||
| setTidbSpecDefault(tc) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.File.MaxBackups).Should(Equal(tidbLogMaxBackups)) | ||
| g.Expect(*tc.Spec.TiDB.Config.OOMAction).Should(Equal(oomAction)) | ||
|
|
||
| tc = newTidbCluster() | ||
| infoLevel := "info" | ||
| tc.Spec.TiDB.Config = &v1alpha1.TiDBConfig{ | ||
| OOMAction: &oomAction, | ||
| Log: &v1alpha1.Log{ | ||
| Level: &infoLevel, | ||
| }, | ||
| } | ||
| setTidbSpecDefault(tc) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.File.MaxBackups).Should(Equal(tidbLogMaxBackups)) | ||
| g.Expect(*tc.Spec.TiDB.Config.OOMAction).Should(Equal(oomAction)) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.Level).Should(Equal(infoLevel)) | ||
|
|
||
| tc = newTidbCluster() | ||
| fileName := "slowlog.log" | ||
| tc.Spec.TiDB.Config = &v1alpha1.TiDBConfig{ | ||
| OOMAction: &oomAction, | ||
| Log: &v1alpha1.Log{ | ||
| Level: &infoLevel, | ||
| File: &v1alpha1.FileLogConfig{ | ||
| Filename: &fileName, | ||
| }, | ||
| }, | ||
| } | ||
| setTidbSpecDefault(tc) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.File.MaxBackups).Should(Equal(tidbLogMaxBackups)) | ||
| g.Expect(*tc.Spec.TiDB.Config.OOMAction).Should(Equal(oomAction)) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.Level).Should(Equal(infoLevel)) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.File.Filename).Should(Equal(fileName)) | ||
|
|
||
| tc = newTidbCluster() | ||
| maxSize := 600 | ||
| tc.Spec.TiDB.Config = &v1alpha1.TiDBConfig{ | ||
| OOMAction: &oomAction, | ||
| Log: &v1alpha1.Log{ | ||
| Level: &infoLevel, | ||
| File: &v1alpha1.FileLogConfig{ | ||
| Filename: &fileName, | ||
| MaxSize: &maxSize, | ||
| }, | ||
| }, | ||
| } | ||
| setTidbSpecDefault(tc) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.File.MaxSize).Should(Equal(maxSize)) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.File.MaxBackups).Should(Equal(tidbLogMaxBackups)) | ||
| g.Expect(*tc.Spec.TiDB.Config.OOMAction).Should(Equal(oomAction)) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.Level).Should(Equal(infoLevel)) | ||
| g.Expect(*tc.Spec.TiDB.Config.Log.File.Filename).Should(Equal(fileName)) | ||
|
|
||
| } | ||
|
|
||
| func newTidbCluster() *v1alpha1.TidbCluster { | ||
| return &v1alpha1.TidbCluster{} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.