Skip to content

Commit

Permalink
improve note and revise idc config (#1904)
Browse files Browse the repository at this point in the history
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
  • Loading branch information
Yisaer and sre-bot authored Mar 11, 2020
1 parent 0fb5f07 commit e52c2fd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 4 additions & 2 deletions charts/tidb-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,11 @@ admissionWebhook:
## failurePolicy are applied to ValidatingWebhookConfiguration which affect tidb-admission-webhook
## refer to https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#failure-policy
failurePolicy:
## the validation webhook would check the request of the given resources, and the failurePolicy is recommended as Ignore
## the validation webhook would check the request of the given resources.
## If the kubernetes api-server version >= 1.15.0, we recommend the failurePolicy as Fail, otherwise, as Ignore.
validation: Ignore
## the mutation webhook would mutate the request of the given resources, and the failurePolicy is recommended as Ignore
## the mutation webhook would mutate the request of the given resources.
## If the kubernetes api-server version >= 1.15.0, we recommend the failurePolicy as Fail, otherwise, as Ignore.
mutation: Ignore
## tidb-admission-webhook deployed as kubernetes apiservice server
## refer to https://github.com/openshift/generic-admission-server
Expand Down
4 changes: 4 additions & 0 deletions ci/deploy_tidb_operator_staging.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,16 @@ scheduler:
replicas: 2
admissionWebhook:
create: true
replicas: 2
validation:
statefulSets: true
pods: true
pingcapResources: false
mutation:
pingcapResources: true
failurePolicy:
validation: Fail
mutation: Fail
features:
- AutoScaling=true
'''
Expand Down

0 comments on commit e52c2fd

Please sign in to comment.