Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dependencies chart local-storage into tidb-cluster chart #1050

Closed
yylt opened this issue Oct 25, 2019 · 4 comments
Closed

add dependencies chart local-storage into tidb-cluster chart #1050

yylt opened this issue Oct 25, 2019 · 4 comments
Labels
type/question Further information is requested

Comments

@yylt
Copy link

yylt commented Oct 25, 2019

Question

default value of storageClassName is local-storage in tidb-cluster, so should we add local-storage chart as dependencies?

local-stroage chart:
https://github.com/kubernetes-incubator/external-storage/tree/master/local-volume/helm
@aylei aylei added the type/question Further information is requested label Nov 11, 2019
@aylei
Copy link
Contributor

aylei commented Nov 11, 2019

ping @cofyc @Yisaer

@Yisaer
Copy link
Contributor

Yisaer commented Nov 11, 2019

As local-storage is necessasy for Operator only in prod, I think there is no need to add local-storage as dependencies currently.

@tennix
Copy link
Member

tennix commented Nov 11, 2019

#1111 We will remove the local storage class name to make tidb-cluster able to deploy in any environment which has a default PV provider.

@aylei
Copy link
Contributor

aylei commented Nov 15, 2019

closed in favor of #1111
feel free to reopen this if there is more discussions @yylt

@aylei aylei closed this as completed Nov 15, 2019
yahonda pushed a commit that referenced this issue Dec 27, 2021
@handlerww
en, zh: bump TiDB Operator charts version to v1.2.0-alpha.1 (#1050)
f4cd26e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tennix @Yisaer @aylei @yylt