Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Source Range IP settings on Service Loadbalancers #2097

Closed
RobbyKK opened this issue Apr 1, 2020 · 2 comments
Closed

Enable Source Range IP settings on Service Loadbalancers #2097

RobbyKK opened this issue Apr 1, 2020 · 2 comments
Labels
status/help-wanted Extra attention is needed

Comments

@RobbyKK
Copy link

RobbyKK commented Apr 1, 2020

Feature Request

Is your feature request related to a problem? Please describe:
There are security concerns in Security Groups created by TiDB and Grafana Service LoadBalancers where by default it creates a 0.0.0.0/0 inbound rule.
These ingress/inbound rules should instead be limited to allowed access only

Describe the feature you'd like:
Enable Limiting of Source IP Ranges in Service LoadBalancers(spec.loadBalancerSourceRanges)
https://kubernetes.io/docs/concepts/services-networking/service/#aws-nlb-support

Describe alternatives you've considered:
We can directly edit Kubernetes Services but that can be overwritten anytime.
Enabling this would enable better config management.

Teachability, Documentation, Adoption, Migration Strategy:
If this is enabled user will only have to set the allowed access ips here:
https://github.com/pingcap/tidb-operator/blob/v1.0.6/deploy/modules/aws/tidb-cluster/values/default.yaml#L10

@DanielZhangQD
Copy link
Contributor

@RobbyKK Thanks for reporting this issue!
Would you please help submit PR for the fix?

@cofyc cofyc added the status/help-wanted Extra attention is needed label Jun 8, 2020
@DanielZhangQD
Copy link
Contributor

close this via #2610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants