Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP:Support Service LoadBalancerSourceRanges #2610

Merged
merged 10 commits into from
Jun 8, 2020
Merged

UCP:Support Service LoadBalancerSourceRanges #2610

merged 10 commits into from
Jun 8, 2020

Conversation

shonge
Copy link
Member

@shonge shonge commented Jun 2, 2020

What problem does this PR solve?

UCP: #2586
Close: #2586
Resolve: #2564

What is changed and how does it work?

  1. Add loadBalancerSourceRanges to service spec.
  2. Expose it on the TiDB Service and Monitor Service.
  3. Add some unit tests for setting LoadBalancerSourceRanges on the TiDB Service and Monitor Service.

Check List

Tests

  • Unit test
  • E2E test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support LoadBalancerSourceRanges in the ServiceSpec for the TidbCluster and TidbMonitor.

@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

Thanks for your pull request. Pick up issue #2586 and reopen this PR

@sre-bot sre-bot closed this Jun 2, 2020
@Yisaer Yisaer reopened this Jun 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

Thanks for your pull request. Pick up issue #2586 and reopen this PR

@sre-bot sre-bot closed this Jun 3, 2020
@you06 you06 reopened this Jun 3, 2020
Yisaer
Yisaer suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The REST LGTM

pkg/apis/pingcap/v1alpha1/types.go Outdated Show resolved Hide resolved
weekface
weekface previously approved these changes Jun 3, 2020
View reviewed changes
@zjj2wry
Copy link
Contributor

zjj2wry commented Jun 4, 2020

I think it would be better to add a validation, to avoid service create failure but others success

@zjj2wry
Copy link
Contributor

zjj2wry commented Jun 4, 2020

@shonge https://github.com/kubernetes/kubernetes/blob/master/pkg/api/service/util.go#L44:6-L68

@shonge
Copy link
Member Author

shonge commented Jun 5, 2020

I think it would be better to add a validation, to avoid service create failure but others success

Update.

zjj2wry
zjj2wry approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@zjj2wry zjj2wry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjj2wry
Copy link
Contributor

zjj2wry commented Jun 5, 2020

/assign @Yisaer for approve

@Yisaer Yisaer merged commit 356109b into pingcap:master Jun 8, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request Jun 8, 2020
@shonge @sre-bot
cherry pick pingcap#2610 to release-1.1
3f4e61c 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-1.1 in PR #2640

@DanielZhangQD DanielZhangQD mentioned this pull request Jun 8, 2020
Closed
Yisaer pushed a commit that referenced this pull request Jun 8, 2020
@sre-bot
cherry pick #2610 to release-1.1 (#2640)
b72e346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjj2wry zjj2wry zjj2wry approved these changes

@Yisaer Yisaer Yisaer approved these changes

@weekface weekface weekface left review comments

@DanielZhangQD DanielZhangQD Awaiting requested review from DanielZhangQD

@cofyc cofyc Awaiting requested review from cofyc

Assignees
No one assigned
Labels
contribution needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support loadBalancerSourceRanges in ServiceSpec If possible please add loadBalancerSourceRanges
7 participants
@shonge @sre-bot @zjj2wry @weekface @cofyc @Yisaer @you06