Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add a CI job to run checks automatically? #391

Closed
cofyc opened this issue Apr 15, 2019 · 2 comments
Closed

RFC: Add a CI job to run checks automatically? #391

cofyc opened this issue Apr 15, 2019 · 2 comments

Comments

@cofyc
Copy link
Contributor

cofyc commented Apr 15, 2019

Why:

make check fails currently, if there is a CI job to run make check or make check-all automatically and we can know and fix it before PR is merged.

$ make check
# govet doesn't work with retool for Go 1.11
# so install separately
linting
CGO_ENABLED=0 retool do revive -formatter friendly -config revive.toml $($(go list ./... | grep -vE "pkg/client" | grep -vE "zz_generated"))
/bin/sh: 1: github.com/pingcap/tidb-operator/cmd/controller-manager: not found
gofmt checking
gofmt -s -l -w $(find $(go list ./... | grep -vE "pkg/client" | grep -vE "zz_generated" | sed 's|github.com/pingcap/tidb-operator/||') -name "*.go") 2>&1| awk '{ print } END { if (NR > 0) { exit 1 } }'
tests/fault.go
Makefile:88: recipe for target 'check-static' failed
make: *** [check-static] Error 1

How:

  • travis / circle CI job
  • jenkins job
@cofyc
Copy link
Contributor Author

cofyc commented Apr 15, 2019

Oh, current Jenkins job ci/pingcap_tidb_operator_build_dind.groovy runs make check. My mistake.

@cofyc
Copy link
Contributor Author

cofyc commented Apr 15, 2019

make check will be fixed in #390.

@cofyc cofyc closed this as completed Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant