Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove monitor config job check #390

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

xiaojingchen
Copy link
Contributor

No description provided.

@shuijing198799
Copy link
Contributor

LGTM

@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

shuijing198799
shuijing198799 previously approved these changes Apr 15, 2019
@qiffang qiffang self-requested a review April 15, 2019 10:02
@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

@qiffang
Copy link
Contributor

qiffang commented Apr 15, 2019

LGTM

qiffang
qiffang previously approved these changes Apr 15, 2019
@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

2 similar comments
@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiaojingchen xiaojingchen merged commit 721531e into pingcap:master Apr 15, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* en: revise the tidbcluster scaling doc

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants