Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: logStop not working #5249

Closed
derhoerit opened this issue Aug 16, 2023 · 8 comments · Fixed by #5754
Closed

br: logStop not working #5249

derhoerit opened this issue Aug 16, 2023 · 8 comments · Fixed by #5754
Labels

Comments

@derhoerit
Copy link

derhoerit commented Aug 16, 2023

Bug Report

What version of Kubernetes are you using?
1.27

What version of TiDB Operator are you using?
1.5.0

What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods??
do-block-storage (default), do-block-storage-retain, do-block-storage-xfs , do-block-storage-xfs-retain

What's the status of the TiDB cluster pods?
All Running

What did you do?

  1. Deployed TiDB Via Kubernetes
  2. Setup https://docs.pingcap.com/tidb-in-kubernetes/stable/backup-to-aws-s3-using-br#log-backup
  3. Delete Backup without stopping backup Job first
  4. Rerun job
  5. Error Occured, try to edit backup by edit logStop: true
  6. Nothing happens, try to delete backup and apply config again with logStop: true appended
  7. Nothing happens. Still Error: It supports single stream log task currently: [BR:Stream:ErrStreamLogTaskExist]stream task already exists

What did you expect to see?
Backup state stopped

What did you see instead?
Error: It supports single stream log task currently: [BR:Stream:ErrStreamLogTaskExist]stream task already exists
I see in my S3 the backup is still running. But i can't debug and make it stop.

@derhoerit
Copy link
Author

derhoerit commented Aug 16, 2023

I try to add cleanPolicy: OnFailure just testing is the edited yaml is working or not. After adding that, the clean policy is running and backup is deleted. But the backup is still running in background process.

@derhoerit derhoerit changed the title BR logStop not working br: logStop not working Aug 16, 2023
@fanjlii
Copy link

fanjlii commented May 7, 2024

I also encountered this problem

@csuzhangxc
Copy link
Member

The log backup is running in TiKV (in the background), currently, it doesn't support to be stopped via Backup CR.

@derhoerit
Copy link
Author

@fanjlii I have found a way how to stop it. By using tidb community tollkit.
Please see this: https://docs.pingcap.com/tidb/stable/br-pitr-manual#stop-and-restart-a-backup-task

@fanjlii
Copy link

fanjlii commented May 8, 2024

@fanjlii I have found a way how to stop it. By using tidb community tollkit. Please see this: https://docs.pingcap.com/tidb/stable/br-pitr-manual#stop-and-restart-a-backup-task
Thx, I later delete the etcd data directly and it works fine. tiup ctl:v7.5.0 etcd del"/tidb/br-stream/info/log-backup"

@sergeymineyev
Copy link

what is the status of this issue. Is it planned to be fixed ?

@csuzhangxc
Copy link
Member

what is the status of this issue. Is it planned to be fixed ?

Can you stop the log backup if the Backup CR is still exist? ref https://docs.pingcap.com/tidb-in-kubernetes/stable/backup-to-aws-s3-using-br#stop-log-backup

@sergeymineyev
Copy link

sergeymineyev commented Sep 19, 2024

what is the status of this issue. Is it planned to be fixed ?

Can you stop the log backup if the Backup CR is still exist? ref https://docs.pingcap.com/tidb-in-kubernetes/stable/backup-to-aws-s3-using-br#stop-log-backup

It works only if log backup is in running state. if log backup reaches an error state, setting logStop to true does nothing. Given that there is no way to know the status log backup (outside of tiup) logStop isn't very useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants