-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop the running log backup when deleting CR #5754
Conversation
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-br |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5754 +/- ##
===========================================
- Coverage 61.47% 20.78% -40.69%
===========================================
Files 235 219 -16
Lines 30653 30965 +312
===========================================
- Hits 18843 6436 -12407
- Misses 9920 23616 +13696
+ Partials 1890 913 -977
|
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-br |
1 similar comment
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-br |
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
/run-pull-e2e-kind-br |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc, WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.6 |
/cherry-pick release-1.5 |
Co-authored-by: csuzhangxc <csuzhangxc@gmail.com>
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
In the previous operator version, delete backup CR will do no clean up on running log backup.
Users may mis-operator and find it hard to running task.
Closes #5249
What is changed and how does it work?
Add enum for cleanPolicy, make input standardized.
Now, only
Retain;OnFailure;Delete
are accepted as cleanPolicy input, and default isRetain
.(This is actually no change to user behavior.)
Add finalizer and clean logic check for on-going log backup
All log backup will have finalizer now. Operator will check if the log backup "on track". If so, a new task to stop log backup will run.
The "on track" state is
BackupScheduled || BackupPrepare || BackupRunning || BackupPaused || BackupStop
. We lack the ability to check whether the log backup should be stopped if it failed. If the task is on fail states, we do not provide auto cleaning.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.