Stop the running log backup when deleting CR (#5754) #5765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5754
What problem does this PR solve?
In the previous operator version, delete backup CR will do no clean up on running log backup.
Users may mis-operator and find it hard to running task.
What is changed and how does it work?
Add enum for cleanPolicy, make input standardized.
Now, only
Retain;OnFailure;Delete
are accepted as cleanPolicy input, and default isRetain
.(This is actually no change to user behavior.)
Add finalizer and clean logic check for on-going log backup
All log backup will have finalizer now. Operator will check if the log backup "on track". If so, a new task to stop log backup will run.
The "on track" state is
BackupScheduled || BackupPrepare || BackupRunning || BackupPaused || BackupStop
. We lack the ability to check whether the log backup should be stopped if it failed. If the task is on fail states, we do not provide auto cleaning.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.