Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS terraform manifest and chart version selection is hard-coded #640

Closed
gregwebs opened this issue Jul 5, 2019 · 3 comments · Fixed by #646
Closed

AWS terraform manifest and chart version selection is hard-coded #640

gregwebs opened this issue Jul 5, 2019 · 3 comments · Fixed by #646
Assignees
@aylei
Labels
area/terraform cloud/aws Amazon Web Services

Comments

@gregwebs
Copy link
Contributor

gregwebs commented Jul 5, 2019

Feature Request

AWS terraform hardcodes the beta 3 release in a few places. We should have one variable to set the version of charts & manifests.

We also need the ability to specify using a version that is not released as a helm chart. This includes both

  • A specific git version
  • The (dirty) local copy for development or otherwise making local changes

Specifying a git version may possibly this be satisfied by using a local copy since one can checkout the repo at that git version.
@gregwebs gregwebs added area/terraform cloud/aws Amazon Web Services labels Jul 5, 2019
@gregwebs gregwebs mentioned this issue Jul 5, 2019
Closed
@aylei
Copy link
Contributor

aylei commented Jul 8, 2019

Actually the version is configurable:

tidb-operator/deploy/aws/tidb-cluster/variables.tf

Line 101 in 7fc6aac

variable "tidb_cluster_chart_version" {

@gregwebs
Copy link
Contributor Author

gregwebs commented Jul 8, 2019

The tidb-operator module also needs to also have a variable:

tidb-operator/deploy/aws/tidb-operator/main.tf

Line 52 in 7fc6aac

kubectl apply -f https://raw.githubusercontent.com/pingcap/tidb-operator/v1.0.0-beta.3/manifests/crd.yaml

@aylei aylei self-assigned this Jul 8, 2019
@aylei
Copy link
Contributor

aylei commented Jul 8, 2019 •
edited
Loading

Good catch, I will fix this.

@aylei aylei mentioned this issue Jul 9, 2019
Merged
yahonda pushed a commit that referenced this issue Dec 27, 2021
@mikechengwei @ran-huang @DanielZhangQD
zh: aggregate multiple TiDB Monitor data by thanos query (#640)
1d31aa6 
* init mutiple tidbmonitor aggreate

* init mutiple tidbmonitor aggreate

* init mutiple tidbmonitor aggreate

* init mutiple tidbmonitor aggreate

* fix thanos doc

* fix thanos doc

* fix thanos doc

* fix thanos doc

* Apply suggestions from code review

Co-authored-by: Ran <huangran@pingcap.com>

* fix thanos doc

* fix thanos doc

* Update zh/aggregate-multiple-cluster-monitor-data.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Update zh/aggregate-multiple-cluster-monitor-data.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aylei aylei

Labels
area/terraform cloud/aws Amazon Web Services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Several small fixes for terraform aws aylei/tidb-operator
2 participants
@gregwebs @aylei