Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick of #853: configure resources for all containers #1119

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Nov 7, 2019

Cherry pick of #853 on release-1.0.

#853: Support confiugring resources requests and limits for all

…of tidb cluster

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei force-pushed the automated-cherry-pick-of-#853-upstream-release-1.0 branch from 763a493 to 098334d Compare November 7, 2019 14:37
@aylei aylei requested review from tennix and weekface November 7, 2019 14:37
@aylei
Copy link
Contributor Author

aylei commented Nov 7, 2019

@weekface @tennix PTAL

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add scheduledBackup.resources in values.yaml

@aylei
Copy link
Contributor Author

aylei commented Nov 8, 2019

@weekface Nice catch
Addressed, PTAL.

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

weekface commented Nov 8, 2019

/run-e2e-in-kind

@tennix tennix changed the title Automated cherry pick of #853: Support confiugring resources requests and limits for all Cherry pick of #853: configure resources for all containers Nov 8, 2019
@tennix tennix merged commit f8a0379 into pingcap:release-1.0 Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants