Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tidb-init-job chart templates timezone bug #1174

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

shonge
Copy link
Member

@shonge shonge commented Nov 18, 2019

What problem does this PR solve?

set timezone and tidb-init-job not work

What is changed and how does it work?

fix helm chart template

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Thank you.

LGTM

@weekface
Copy link
Contributor

/run-e2e-in-kind

@weekface
Copy link
Contributor

Can you please open a pr to master branch too?

@weekface weekface merged commit 338b685 into pingcap:release-1.0 Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants