Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Terraform Google provider version to avoid use_ip_aliases error #1206

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Pin Terraform Google provider version to avoid use_ip_aliases error #1206

merged 1 commit into from
Nov 21, 2019

Conversation

tennix
Copy link
Member

@tennix tennix commented Nov 21, 2019

What problem does this PR solve?

This PR adds a workaround for #1205

What is changed and how does it work?

This PR restricts the Google Terraform provider to less than 2.19.

Check List

Tests

  • Manual test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release-1.0 branch

Does this PR introduce a user-facing change?:

Fix google terraform module `use_ip_aliases` error.

@tennix tennix added area/terraform cloud/gcp Google Cloud Platform labels Nov 21, 2019
@tennix
Copy link
Member Author

tennix commented Nov 21, 2019

/run-e2e-test

@tennix
Copy link
Member Author

tennix commented Nov 21, 2019

This error also breaks our CI https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/build_tidb_operator_master_kind/detail/build_tidb_operator_master_kind/155/pipeline#step-30-log-681

@tennix tennix requested a review from cofyc November 21, 2019 05:09
@cofyc
Copy link
Contributor

cofyc commented Nov 21, 2019

why the CI on pull request does not fail? cc @onlymellb

@cofyc
Copy link
Contributor

cofyc commented Nov 21, 2019

local cache?

onlymellb
onlymellb approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aylei
aylei approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit ebc4486 into pingcap:master Nov 21, 2019
@tennix tennix deleted the pin-terraform-google-version branch November 21, 2019 05:52
@DanielZhangQD DanielZhangQD mentioned this pull request Dec 2, 2019
Closed
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@DanielZhangQD
zh: add faq about data reliability (#1206)
0f67a9c
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@qiancai
en: add faq about data reliability #1206 (#1216)
5d2a6f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei approved these changes

@onlymellb onlymellb onlymellb approved these changes

@cofyc cofyc cofyc approved these changes

Assignees
No one assigned
Labels
area/terraform cloud/gcp Google Cloud Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tennix @cofyc @onlymellb @aylei