Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e nil point dereference #1221

Merged
merged 5 commits into from
Nov 25, 2019

Conversation

onlymellb
Copy link
Contributor

@onlymellb onlymellb commented Nov 22, 2019

What problem does this PR solve?

Check List

Tests

  • E2E test

Code changes

  • Has Go code change

Does this PR introduce a user-facing change?:

None

@onlymellb
Copy link
Contributor Author

/run-e2e-tests

weekface
weekface previously approved these changes Nov 22, 2019
cofyc
cofyc previously approved these changes Nov 22, 2019
@onlymellb onlymellb dismissed stale reviews from cofyc and weekface via 6d1c7f6 November 22, 2019 11:16
@onlymellb
Copy link
Contributor Author

/run-e2e-tests

@onlymellb onlymellb added test/e2e e2e test status/PTAL PR needs to be reviewed labels Nov 22, 2019
@onlymellb
Copy link
Contributor Author

/run-e2e-tests

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onlymellb
Copy link
Contributor Author

/run-e2e-tests

@onlymellb onlymellb merged commit e7f3144 into pingcap:master Nov 25, 2019
@onlymellb onlymellb deleted the fix-e2e-nil-point-dereference branch November 25, 2019 03:34
aylei pushed a commit that referenced this pull request Nov 26, 2019
* fix e2e nil point dereference

* fix CI

* fix the judgment condition of ci script
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/PTAL PR needs to be reviewed test/e2e e2e test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants