bugfix: get time string from current time instead of pod name #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
commented
Nov 25, 2019
| timestamp=$(echo ${POD_NAME}|awk -F- '{print $(NF-1)}') | ||
| ## use UTC time zone to resolve timestamp, avoiding different parsing results due to different default time zones | ||
| backupName=scheduled-backup-`date -u -d @${timestamp} "+%Y%m%d-%H%M%S"` | ||
| backupName=scheduled-backup-`date "+%Y%m%d-%H%M%S"` |
There was a problem hiding this comment.
Use TZ env timezone information of the pod instead of UTC. @onlymellb
onlymellb
reviewed
Nov 25, 2019
| timestamp=$(echo ${POD_NAME}|awk -F- '{print $(NF-1)}') | ||
| ## use UTC time zone to resolve timestamp, avoiding different parsing results due to different default time zones | ||
| backupName=scheduled-backup-`date -u -d @${timestamp} "+%Y%m%d-%H%M%S"` | ||
| backupName=scheduled-backup-`date "+%Y%m%d-%H%M%S"` |
There was a problem hiding this comment.
I recommend continuing to use UTC timestamps date -u "+%Y%m%d-%H%M%S"
There was a problem hiding this comment.
It should be strange if the user set TZ already.
|
/run-e2e-tests |
|
Does this impact the restore from the scheduled backup? |
|
The generated name is the same as the old way: |
weekface
added a commit
to weekface/tidb-operator
that referenced
this pull request
Nov 26, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #1227
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: