Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[host network] keep backward compatibility in release-1.0 #1287

Merged
merged 2 commits into from
Dec 5, 2019
Merged

[host network] keep backward compatibility in release-1.0 #1287

merged 2 commits into from
Dec 5, 2019

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Dec 5, 2019

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has CI related scripts change
  • Has documents change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

bugfix: don't set DNSPolicy if hostNetwork is not enabled to keep backward compatibility

@cofyc cofyc changed the base branch from master to release-1.0 December 5, 2019 07:30
@claassistantio
Copy link

claassistantio commented Dec 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cofyc cofyc requested review from aylei and weekface December 5, 2019 07:31
@cofyc
Copy link
Contributor Author

cofyc commented Dec 5, 2019

/run-e2e-test

weekface
weekface reviewed Dec 5, 2019
View reviewed changes
pkg/manager/member/pd_member_manager.go Outdated
@@ -522,6 +553,7 @@ func (pmm *pdMemberManager) getNewPDSetForTidbCluster(tc *v1alpha1.TidbCluster)
},
},
})
podSpec.Containers[0].Env = env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only add env when using hostNetwork?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.. sorry, fixed

weekface
weekface approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed the stability tests.

LGTM

@weekface
Copy link
Contributor

weekface commented Dec 5, 2019

/run-e2e-test

aylei
aylei approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

weekface commented Dec 5, 2019

/run-e2e-tests

@cofyc cofyc merged commit 8f4027e into pingcap:release-1.0 Dec 5, 2019
@cofyc cofyc mentioned this pull request Dec 16, 2019
Closed
@aylei aylei mentioned this pull request Dec 16, 2019
Closed
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@KanShiori
en, zh: Update description about toolImage field of BR (#1287)
38c77a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cofyc @claassistantio @weekface @aylei