Expose ephemeral-storage in resource config #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-all-test |
weekface
reviewed
Dec 24, 2019
Co-Authored-By: weekface <weekface@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-all-test |
|
/run-e2e-test |
weekface
approved these changes
Dec 25, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aylei rayingecho@gmail.com
close #1390
close #1395
Tests
Some UT cases are removed because the type constraint makes the quantity format error will never happen in the Go code, instead, we will encounter an error when post a wrong request body to kube-apiserver, which could be verified in e2e or stability test.
Does this PR introduce a user-facing change?:
@cofyc @weekface @tennix @Yisaer PTAL