release v1.1.0-beta.1 #1459
Merged
release v1.1.0-beta.1 #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aylei
requested review from
tennix,
weekface,
Yisaer,
shuijing198799,
cofyc and
LinuxGit
Signed-off-by: Aylei <rayingecho@gmail.com>
aylei
force-pushed
the
1451-beta-note
branch
from
0d66ecd
to
5206406
Compare
|
/run-all-test |
CaitinChen
reviewed
Jan 3, 2020
CHANGELOG-1.1.md
Outdated
| # TiDB Operator v1.1.0-beta.1 Release Notes | ||
|
|
||
| This is a pre-release of `v1.1.0`, which focuses on the usability, extensibility and security of TiDB Operator. While we encourage usage in non-critical environments, | ||
| it is **NOT** recommended to use this version in critical environments. |
There was a problem hiding this comment.
Please move this line to Line 3.
CaitinChen
reviewed
Jan 3, 2020
Co-Authored-By: Caitin <34535727+CaitinChen@users.noreply.github.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
CaitinChen
reviewed
Jan 3, 2020
CaitinChen
reviewed
Jan 3, 2020
There was a problem hiding this comment.
Please remove the period after each PR description.
Please use official and standard words. For example, use "TiKV" instead of "tikv". But you can use tikv("tikv" with backquotes) if you write "tikv" in the code.
I don't understand the meaning of some PR description. If my suggestion changes the meaning, please ignore it.
CHANGELOG-1.1.md
Outdated
| - Add backup-manager tool for support backup、restore and clean backup data ([#694](https://github.com/pingcap/tidb-operator/pull/694), [@onlymellb](https://github.com/onlymellb)) | ||
| - Add `affinity` to pump/drainer configration ([#741](https://github.com/pingcap/tidb-operator/pull/741), [@weekface](https://github.com/weekface)) | ||
| - Fix tikv scale in failure in some cases after tikv failover ([#726](https://github.com/pingcap/tidb-operator/pull/726), [@onlymellb](https://github.com/onlymellb)) | ||
| - `NONE` ([#719](https://github.com/pingcap/tidb-operator/pull/719), [@xiaojingchen](https://github.com/xiaojingchen)) |
There was a problem hiding this comment.
There is no user-facing change in this PR, I will remove this
Co-Authored-By: Caitin <34535727+CaitinChen@users.noreply.github.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
|
Thank you very much @CaitinChen ! I've addressed the comments and removes all the period, PTAL again |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-all-test |
CaitinChen
reviewed
Jan 6, 2020
CHANGELOG-1.1.md
Outdated
| - Support backup to gcs ([#1127](https://github.com/pingcap/tidb-operator/pull/1127), [@onlymellb](https://github.com/onlymellb)) | ||
| - Support configuring `net.ipv4.tcp_keepalive_time` and `net.core.somaxconn` for TiDB and configuring `net.core.somaxconn` for TiKV ([#1107](https://github.com/pingcap/tidb-operator/pull/1107), [@DanielZhangQD](https://github.com/DanielZhangQD)) | ||
| - Add basic e2e tests for aggregated apiserver ([#1109](https://github.com/pingcap/tidb-operator/pull/1109), [@aylei](https://github.com/aylei)) | ||
| - Add switch `enablePVReclaim` option to reclaim pv when tidb-operator scales in TiKV or PD ([#1037](https://github.com/pingcap/tidb-operator/pull/1037), [@onlymellb](https://github.com/onlymellb)) |
There was a problem hiding this comment.
Suggested change
| - Add switch `enablePVReclaim` option to reclaim pv when tidb-operator scales in TiKV or PD ([#1037](https://github.com/pingcap/tidb-operator/pull/1037), [@onlymellb](https://github.com/onlymellb)) | |
| - Add switch `enablePVReclaim` option to reclaim PV when tidb-operator scales in TiKV or PD ([#1037](https://github.com/pingcap/tidb-operator/pull/1037), [@onlymellb](https://github.com/onlymellb)) |
There was a problem hiding this comment.
What does "switch enablePVReclaim option" mean? Is "switch" a verb or a noun?
There was a problem hiding this comment.
a verb, it is better to remove this verb
CHANGELOG-1.1.md
Outdated
| - Upgrade the default TiDB version to v3.0.4 ([#837](https://github.com/pingcap/tidb-operator/pull/837), [@shonge](https://github.com/shonge)) | ||
| - Fix values file customization for tidb-operator on Aliyun ([#971](https://github.com/pingcap/tidb-operator/pull/971), [@DanielZhangQD](https://github.com/DanielZhangQD)) | ||
| - Add the `maxFailoverCount` limit to TiKV ([#965](https://github.com/pingcap/tidb-operator/pull/965), [@weekface](https://github.com/weekface)) | ||
| - The custom tidb-operator values can be properly set now in terraform script for AWS ([#946](https://github.com/pingcap/tidb-operator/pull/946), [@aylei](https://github.com/aylei)) |
There was a problem hiding this comment.
To keep a consistent style, start each PR description with a verb.
Co-Authored-By: Caitin <34535727+CaitinChen@users.noreply.github.com>
CaitinChen
reviewed
Jan 6, 2020
|
Should webhook for pod-admission be enabled in the default in release v1.1.0-beta.1? @aylei |
Co-Authored-By: Caitin <34535727+CaitinChen@users.noreply.github.com>
|
/merge |
|
Your auto merge job has been accepted, waiting for 1493, 1484 |
|
/run-all-tests |
|
@aylei merge failed. |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/merge |
|
Your auto merge job has been accepted, waiting for 1491 |
|
/run-all-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-all-tests |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aylei rayingecho@gmail.com
#1451
Release v1.1.0-beta.1.
Because this is a pre-release, the version used by terraform scripts is not bumped.