Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the drainer name configurable #1604

Merged
merged 9 commits into from
Feb 26, 2020
Merged

make the drainer name configurable #1604

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
00f36ec
make the drainer name configurable
gregwebs Jan 29, 2020
7d17980
Merge branch 'master' into drainer-name
cofyc Feb 3, 2020
91a09b2
Merge branch 'master' into drainer-name
Yisaer Feb 4, 2020
35c5cdd
Merge branch 'master' into drainer-name
Yisaer Feb 4, 2020
58a2e12
Merge branch 'master' into drainer-name
cofyc Feb 13, 2020
f2a5092
Merge branch 'master' into drainer-name
cofyc Feb 17, 2020
9d7a8b2
Merge branch 'master' into drainer-name
cofyc Feb 21, 2020
7399fa9
add a warning about updating the drainer name
gregwebs Feb 24, 2020
fdf97c7
Merge branch 'master' into drainer-name
Yisaer Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/tidb-drainer/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{{- define "drainer.name" -}}
{{- if .Values.drainerName }}
{{ .Values.drainerName }}
{{- else -}}
{{ .Values.clusterName }}-{{ .Release.Name }}-drainer
{{- end -}}

Expand Down
5 changes: 5 additions & 0 deletions charts/tidb-drainer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
# timezone is the default system timzone
timezone: UTC

# Change the name of the statefulset and pod
# The default is clusterName-ReleaseName-drainer
Comment on lines +8 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we warn user that changing name on existing will cause data loss?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @gregwebs add a notice then we merge this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, warning added

# Do not change the name of an existing running drainer: this is unsupported.
# drainerName:

# clusterName is the TiDB cluster name that should backup from or restore to.
clusterName: demo
clusterVersion: v3.0.8
Expand Down