AutoScaling: adding status type #1853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yisaer
reviewed
Mar 10, 2020
| // BasicAutoScalerSpec describes the basic status for auto-scaling | ||
| type BaseAutoScalerStatus struct { | ||
| // name is the name of the given metric | ||
| Name string `json:"name,omitempty"` |
There was a problem hiding this comment.
The metrics property in AutoScaler is a list. If we need to show the metrics value, we should make the metrics status as list.
There was a problem hiding this comment.
Currently, We use one metric to calculate the autoscaling. So i think it is just show the metric in effect.
Yisaer
reviewed
Mar 10, 2020
Yisaer
reviewed
Mar 10, 2020
Yisaer
reviewed
Mar 10, 2020
Yisaer
reviewed
Mar 10, 2020
|
supported in #2182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Adding autoscaling status type, it includes these item:
Name // name is used to calculate autoscaling. For example: cpu.
CurrentValue // the current value of this metric.
TargetValue // the expect value of this metric.
CurrentReplicas // the current replica of the component.
DesiredReplicas // the expect replica of the component.
Code changes
Does this PR introduce a user-facing change?: