-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PD Config to v3.1.0 #1928
Merged
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fc22e9d
update pd config
a48d74a
Merge branch 'master' into update_pd_config
Yisaer aa08324
updated v3.1.0 configuration
5842dfb
Merge branch 'master' into update_pd_config
Yisaer bb76db0
update docs.html
93f13bc
remove unnecessary configuration
24d6cac
fix go mod tidy
0a32933
revise Note
cbe0713
fix typo error
6aacf61
fix typo
5c16875
Merge branch 'master' into update_pd_config
DanielZhangQD a009485
Merge branch 'master' into update_pd_config
Yisaer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1344,6 +1344,8 @@ spec: | |
description: ElectionInterval is the interval for etcd Raft | ||
election. | ||
type: string | ||
enable-dynamic-config: | ||
type: boolean | ||
enable-grpc-gateway: | ||
description: 'Optional: Defaults to true' | ||
type: boolean | ||
|
@@ -1419,6 +1421,7 @@ spec: | |
level: | ||
description: 'Log level. Optional: Defaults to info' | ||
type: string | ||
sampling: {} | ||
type: object | ||
log-file: | ||
description: Backward compatibility. | ||
|
@@ -1443,6 +1446,11 @@ spec: | |
pd-server: | ||
description: PDServerConfig is the configuration for pd server. | ||
properties: | ||
metric-storage: | ||
description: MetricStorage is the cluster metric storage. | ||
Currently we use prometheus as metric storage, we may | ||
use PD/TiKV as metric storage later. imported from v3.1.0 | ||
type: string | ||
use-region-storage: | ||
description: UseRegionStorage enables the independent region | ||
storage. | ||
|
@@ -1456,6 +1464,10 @@ spec: | |
replication: | ||
description: PDReplicationConfig is the replication configuration. | ||
properties: | ||
enable-placement-rules: | ||
description: When PlacementRules feature is enabled. MaxReplicas | ||
and LocationLabels are not uesd any more. | ||
type: string | ||
max-replicas: | ||
description: 'MaxReplicas is the number of replicas for | ||
each region. Immutable, change should be made through | ||
|
@@ -1465,7 +1477,8 @@ spec: | |
strictly-match-label: | ||
description: StrictlyMatchLabel strictly checks if the label | ||
of TiKV is matched with LocaltionLabels. Immutable, change | ||
should be made through pd-ctl after cluster creation | ||
should be made through pd-ctl after cluster creation imported | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a period at the end of the previous sentence. We should make the description readable. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated. |
||
from v3.1.0 | ||
type: string | ||
type: object | ||
schedule: | ||
|
@@ -1511,6 +1524,17 @@ spec: | |
Immutable, change should be made through pd-ctl after | ||
cluster creation | ||
type: string | ||
enable-cross-table-merge: | ||
description: EnableCrossTableMerge is the option to enable | ||
cross table merge. This means two Regions can be merged | ||
with different table IDs. This option only works when | ||
key type is "table". imported from v3.1.0 | ||
type: string | ||
enable-one-way-merge: | ||
description: EnableOneWayMerge is the option to enable one | ||
way merge. This means a Region can only be merged into | ||
the next region of it. imported from v3.1.0 | ||
type: string | ||
high-space-ratio: | ||
description: HighSpaceRatio is the highest usage ratio of | ||
store which regraded as high space. High space means there | ||
|
@@ -1537,7 +1561,8 @@ spec: | |
leader-schedule-limit: | ||
description: 'LeaderScheduleLimit is the max coexist leader | ||
schedules. Immutable, change should be made through pd-ctl | ||
after cluster creation Optional: Defaults to 4' | ||
after cluster creation Optional: Defaults to 4 imported | ||
from v3.1.0' | ||
format: int64 | ||
type: integer | ||
low-space-ratio: | ||
|
@@ -1640,10 +1665,18 @@ spec: | |
be made through pd-ctl after cluster creation Optional: | ||
Defaults to 1h' | ||
type: string | ||
store-limit-mode: | ||
description: 'StoreLimitMode can be auto or manual, when | ||
set to auto, PD tries to change the store limit values | ||
according to the load state of the cluster dynamically. | ||
User can overwrite the auto-tuned value by pd-ctl, when | ||
the value is overwritten, the value is fixed until it | ||
is deleted. Default: manual' | ||
type: string | ||
tolerant-size-ratio: | ||
description: TolerantSizeRatio is the ratio of buffer size | ||
for balance scheduler. Immutable, change should be made | ||
through pd-ctl after cluster creation | ||
through pd-ctl after cluster creation imported from v3.1.0 | ||
format: double | ||
type: number | ||
type: object | ||
|
@@ -1660,6 +1693,8 @@ spec: | |
description: CertPath is the path of file that contains | ||
X509 certificate in PEM format. | ||
type: string | ||
client-cert-auth: | ||
type: boolean | ||
key-path: | ||
description: KeyPath is the path of file that contains X509 | ||
key in PEM format. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can use
Available since TiDB v3.1.0
to tell the user that this config is available since TiDB v3.1.0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: I added
TiDB
prefix because we should make it clear thatv3.1.0
is the version of TiDB not tidb-operator, etc.