Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS support for Pump and Drainer (#1979) #1984

Merged
merged 3 commits into from
Mar 20, 2020
Merged

TLS support for Pump and Drainer (#1979) #1984

merged 3 commits into from
Mar 20, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 19, 2020

cherry-pick #1979 to release-1.1

What problem does this PR solve?

This PR adds Enable TLS Authentication for Pump and Drainer.

Part of #1855

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

TLS support for Pump and Drainer

@sre-bot sre-bot mentioned this pull request Mar 19, 2020
Merged
DanielZhangQD
DanielZhangQD approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shuijing198799
shuijing198799 approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@shuijing198799 shuijing198799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor

cofyc commented Mar 20, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit cad6905 into pingcap:release-1.1 Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@shuijing198799 shuijing198799 shuijing198799 approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
CanMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @cofyc @shuijing198799 @DanielZhangQD @weekface