Fix TidbMonitor Service Label (#2051) #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 30, 2020 18:22
This reverts commit 727988d.
sre-bot
requested review from
aylei,
cofyc,
DanielZhangQD,
qiffang and
weekface
Yisaer
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2051 to release-1.1
What problem does this PR solve?
Fix #2049
What is changed and how does it work?
Change the label to of the TidbMonitor resources in order to make compatible with the helm 1.0 releases monitor.
It would break the existed
TidbMonitor(users have to delete the existed deployment manually or the prometheus service can't work), asTidbMonitoris not released yet, I think it's ok.Check List
Related changes
Does this PR introduce a user-facing change?: