Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary informer caches (#1504) #2162

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Apr 13, 2020

What problem does this PR solve?

close #1327
close #1406

What is changed and how does it work?

  • Remove informer caches for configmap and secret

These will significantly reduce the memory footprint of tidb-controller-manager.

Check List

Tests

  • Unit test
  • E2E test

Does this PR introduce a user-facing change?:

Remove unnecessary informer caches to reduce the memory footprint of tidb-controller-manager

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@cofyc
Copy link
Contributor

cofyc commented Apr 13, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit 3b2fe37 into pingcap:release-1.1 Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants