Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional containers and volumes in TiDB cluster #2229

Merged
merged 3 commits into from
Jun 19, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ check-setup:
check: check-setup lint tidy check-static check-codegen check-terraform check-boilerplate check-openapi-spec check-crd-groups

check-static:
@ # Not running vet and fmt through metalinter becauase it ends up looking at vendor
@ # Not running vet and fmt through metalinter because it ends up looking at vendor
@echo "gofmt checking"
gofmt -s -l -w $(FILES) 2>&1| $(FAIL_ON_STDOUT)
@echo "go vet check"
Expand Down
29 changes: 29 additions & 0 deletions docs/api-references/docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -3053,6 +3053,35 @@ tidb-operator built envs.
- SLOW_LOG_FILE</p>
</td>
</tr>
<tr>
<td>
<code>additionalContainers</code></br>
<em>
<a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#container-v1-core">
[]Kubernetes core/v1.Container
</a>
</em>
</td>
<td>
<em>(Optional)</em>
<p>Additional containers of the component.</p>
</td>
</tr>
<tr>
<td>
<code>additionalVolumes</code></br>
<em>
<a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#volume-v1-core">
[]Kubernetes core/v1.Volume
</a>
</em>
</td>
<td>
<em>(Optional)</em>
<p>Additional volumes of component pod. Currently this only
supports additional volume mounts for sidecar containers.</p>
</td>
</tr>
</tbody>
</table>
<h3 id="configmapref">ConfigMapRef</h3>
Expand Down
2 changes: 1 addition & 1 deletion hack/update-crd-groups.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ crd_target="$ROOT/manifests/crd.yaml"
export GOBIN="${OUTPUT_BIN}"
PATH="${GOBIN}:${PATH}"

# Enable go modules explicilty.
# Enable go modules explicitly.
export GO111MODULE=on
go install github.com/pingcap/tidb-operator/cmd/to-crdgen

Expand Down
2 changes: 1 addition & 1 deletion hack/update-openapi-spec.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ source "${ROOT}/hack/lib.sh"
export GOBIN="${OUTPUT_BIN}"
PATH="${GOBIN}:${PATH}"

# Enable go modules explicilty.
# Enable go modules explicitly.
export GO111MODULE=on
go install k8s.io/code-generator/cmd/openapi-gen

Expand Down
Loading