-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e CI job use memory storage for etcd #2633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonge
commented
Jun 5, 2020
cofyc
reviewed
Jun 9, 2020
cofyc
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Yisaer
approved these changes
Jun 9, 2020
/merge |
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb-operator
that referenced
this pull request
Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-1.1 in PR #2663 |
Yisaer
pushed a commit
to Yisaer/tidb-operator
that referenced
this pull request
Jun 9, 2020
debug in ci debug ci fix e2e checking add log E2e CI job use memory storage for etcd (pingcap#2633) * support memory storage for etcd in kind * export ETCD_STORAGE_TYPE=memory in e2e_kind.groovy * fix a bug * use KIND_ETCD_DATADIR instead of ETCD_STORAGE_TYPE * fix typos * fix bugs * Revert "fix bugs" This reverts commit 3ae083b. * revert format and simplified extraMounts Hide datasource information for backup job (pingcap#2652) Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com> use crd Update pingcap_tidb_operator_build_kind.groovy
sre-bot
added a commit
that referenced
this pull request
Jun 9, 2020
sre-bot
added a commit
that referenced
this pull request
Jun 10, 2020
* remove statefulsets webhook * fix webhook partition * check in e2e debug in ci debug ci fix e2e checking add log E2e CI job use memory storage for etcd (#2633) * support memory storage for etcd in kind * export ETCD_STORAGE_TYPE=memory in e2e_kind.groovy * fix a bug * use KIND_ETCD_DATADIR instead of ETCD_STORAGE_TYPE * fix typos * fix bugs * Revert "fix bugs" This reverts commit 3ae083b. * revert format and simplified extraMounts Hide datasource information for backup job (#2652) Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com> use crd Update pingcap_tidb_operator_build_kind.groovy * use RunKubectl Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #2619
What is changed and how does it work?
Add an option environment
ETCD_STORAGE_TYPE
, default isdisk
, if set it asmemory
willrunning etcd use memory storage.
Reference:
kubernetes-sigs/kind#845 (comment)
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: