Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e CI job use memory storage for etcd #2633

Merged
merged 12 commits into from
Jun 9, 2020
Merged

Conversation

shonge
Copy link
Member

@shonge shonge commented Jun 5, 2020

What problem does this PR solve?

fix #2619

What is changed and how does it work?

Add an option environment ETCD_STORAGE_TYPE , default is disk, if set it as memory will
running etcd use memory storage.
Reference:
kubernetes-sigs/kind#845 (comment)

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has CI related scripts change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

None

@shonge shonge changed the title E2e etcd in mem E2e CI job use memory storage for etcd Jun 5, 2020
ci/e2e_kind.groovy Outdated Show resolved Hide resolved
hack/e2e.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@cofyc cofyc requested a review from Yisaer June 9, 2020 03:22
@Yisaer
Copy link
Contributor

Yisaer commented Jun 9, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 935520b into pingcap:master Jun 9, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

cherry pick to release-1.1 in PR #2663

@shonge shonge deleted the e2e_etcd_in_mem branch June 9, 2020 04:24
Yisaer pushed a commit to Yisaer/tidb-operator that referenced this pull request Jun 9, 2020
debug in ci

debug ci

fix e2e checking

add log

E2e CI job use memory storage for etcd (pingcap#2633)

* support memory storage for etcd in kind

* export ETCD_STORAGE_TYPE=memory in e2e_kind.groovy

* fix a bug

* use KIND_ETCD_DATADIR instead of ETCD_STORAGE_TYPE

* fix typos

* fix bugs

* Revert "fix bugs"

This reverts commit 3ae083b.

* revert format and simplified extraMounts

Hide datasource information for backup job (pingcap#2652)

Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>

use crd

Update pingcap_tidb_operator_build_kind.groovy
sre-bot added a commit that referenced this pull request Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Song <soog2008@hotmail.com>
Co-authored-by: Song Gao <disxiaofei@163.com>
sre-bot added a commit that referenced this pull request Jun 10, 2020
* remove statefulsets webhook

* fix webhook partition

* check in e2e

debug in ci

debug ci

fix e2e checking

add log

E2e CI job use memory storage for etcd (#2633)

* support memory storage for etcd in kind

* export ETCD_STORAGE_TYPE=memory in e2e_kind.groovy

* fix a bug

* use KIND_ETCD_DATADIR instead of ETCD_STORAGE_TYPE

* fix typos

* fix bugs

* Revert "fix bugs"

This reverts commit 3ae083b.

* revert format and simplified extraMounts

Hide datasource information for backup job (#2652)

Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>

use crd

Update pingcap_tidb_operator_build_kind.groovy

* use RunKubectl

Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: use memory storage for etcd
5 participants