Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imagePullSecrets attribute to all components #2679

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Add imagePullSecrets attribute to all components #2679

merged 2 commits into from
Jun 11, 2020

Conversation

weekface
Copy link
Contributor

What problem does this PR solve?

fixes: #2418

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Add imagePullSecrets attribute to all components

@cofyc
Copy link
Contributor

cofyc commented Jun 11, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit b1d60ba into pingcap:master Jun 11, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request Jun 11, 2020
@weekface @sre-bot
cherry pick pingcap#2679 to release-1.1
1f3c713 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 11, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-1.1 in PR #2681

@weekface weekface deleted the image-pull-secrets branch June 11, 2020 03:12
sre-bot added a commit that referenced this pull request Jun 11, 2020
@sre-bot @weekface
Add imagePullSecrets attribute to all components (#2679) (#2681)
b87d0af 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: weekface <weekface@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@cofyc cofyc cofyc approved these changes

@DanielZhangQD DanielZhangQD Awaiting requested review from DanielZhangQD

Assignees
No one assigned
Labels
CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support to Pull an Image from a Private Registry
4 participants
@weekface @cofyc @sre-bot @Yisaer